-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use CVE and CWE roles from Sphinx 8.1 #8457
Conversation
Note: This changes the CVE URL from https://www.cve.org/CVERecord?id=CVE-%s to https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-%s |
@@ -46,7 +46,7 @@ clean: | |||
-rm -rf $(BUILDDIR)/* | |||
|
|||
install-sphinx: | |||
$(PYTHON) -m pip install --quiet furo olefile sphinx sphinx-copybutton sphinx-inline-tabs sphinxext-opengraph | |||
$(PYTHON) -m pip install -e ..[docs] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why change this to use an editable install?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Force of habit typing -e
!
Which do you prefer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not fussed. I suppose -e
is consistent with our other command in the Makefile that installs an optional dependency.
Line 76 in 97438cb
python3 -m pip install -e .[tests] |
Sphinx 8 doesn't support Python 3.9. Maybe we should hold off on this until Pillow 12? |
Thanks, I've opened sphinx-doc/sphinx#13006 to update it in Sphinx.
Building docs is a different application to the Pillow API's version support policy. And we already upgraded to Sphinx 7.3 (#7985) which also doesn't support Python 3.9 :) Sphinx's support policy is derived from SPEC 0 meaning they support fewer versions than we do. If we required Sphinx to build on all our supported versions, we'd have to use quite old Sphinx versions. |
I think it does support Python 3.9. But that PR did mean that Sphinx didn't support Python 3.8, before we dropped Python 3.8 support from the rest of Pillow in #8183, so your point still stands. |
Yes, this is what I meant 😅 |
Merged and released in https://github.com/sphinx-doc/sphinx/releases/tag/v8.1.1. |
Changes proposed in this pull request:
:cve:
) and CWEs (:cwe:
)extlinks
Makefile
so we install Pillow for docs builds using thedocs
extra, so installs Sphinx 8.1+, and avoids defining the docs dependencies in two places