Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated xz to 5.6.3 #8434

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Updated xz to 5.6.3 #8434

merged 1 commit into from
Oct 2, 2024

Conversation

radarhere
Copy link
Member

@@ -185,7 +185,7 @@ def cmd_msbuild(
cmd_copy(r"src\liblzma\api\lzma\*.h", r"{inc_dir}\lzma"),
],
"headers": [r"src\liblzma\api\lzma.h"],
"libs": [r"liblzma.lib"],
"libs": [r"lzma.lib"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why these changes?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/tukaani-project/xz/releases/tag/v5.6.3

  • MSVC: Rename import library from liblzma.lib to lzma.lib while keeping liblzma.dll name as is. This helps with "pkgconf --msvc-syntax --libs liblzma" because it mungles "-llzma" in liblzma.pc to "lzma.lib".

@hugovk hugovk merged commit 79f95c9 into python-pillow:main Oct 2, 2024
66 of 67 checks passed
@radarhere radarhere deleted the xz branch October 2, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants