Cast int before potentially exceeding INT_MAX #8402
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8401
tablen
is an integerPillow/src/libImaging/Sgi.h
Line 22 in b557876
and before we set it to
im->bands * im->ysize
, we check that the value will be less thanINT_MAX
Pillow/src/libImaging/SgiRleDecode.c
Lines 170 to 172 in b557876
but we then temporarily multiply it by 8, which might exceed
INT_MAX
.Pillow/src/libImaging/SgiRleDecode.c
Lines 181 to 186 in b557876
So this PR casts it to
int64_t
before applying the multiplication.