-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more data to error message #8316
base: main
Are you sure you want to change the base?
Conversation
Could you give an example of how to trigger this error? |
With #8317, |
Would it not be more consistent with the rest of TiffImagePlugin to log the extra information instead? Pillow/src/PIL/TiffImagePlugin.py Lines 1429 to 1435 in eeb3d04
|
It might. Logging is only used in five files in Pillow though (Image, PcxImagePlugin, PngImagePlugin, TiffImagePlugin, helper). |
dc7470f
to
b7248be
Compare
b7248be
to
4eac85c
Compare
4eac85c
to
7cfb3eb
Compare
7cfb3eb
to
60eb058
Compare
60eb058
to
671d780
Compare
I've created #8568 as an alternative to this, using my suggestion of logging. |
This changes the error message from
offset is neither short nor long
to
offset is neither short nor long: Tag ID 273 Field Type 16 Field Size 8 Count 1