Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some improvements to ImageDraw2.
ellipse()
only requiresxy
,Pillow/src/PIL/ImageDraw2.py
Line 132 in 8f62fbd
but that is not the case.
gives
So I've made a change to add
pen
as a required argument toarc()
and other methods.Some of our test code does pass through
pen
asNone
, and uses thebrush
argument for thePen
instead.Pillow/Tests/test_imagedraw2.py
Lines 115 to 120 in 8f62fbd
But even if
pen
isNone
, the fact thatbrush
needs to come afterwards means that a value forpen
is still required.arc()
does not work.Pillow/src/PIL/ImageDraw2.py
Line 114 in 8f62fbd
This is because ImageDraw2
render()
passesoutline
to every method except forline()
, but ImageDrawarc()
doesn't accept that.Pillow/src/PIL/ImageDraw2.py
Lines 104 to 107 in 8f62fbd
Pillow/src/PIL/ImageDraw.py
Lines 174 to 181 in 8f62fbd
I've made a change for that.
start
andend
parameters aren't passed through to ImageDraw. I've added**kwargs
torender()
to allow them to be added.