Remove all WITH_* flags from _imaging.c and other flags #8211
Conversation
| @@ -215,16 +198,12 @@ PyImaging_AsImaging(PyObject *op) { | |||
|
|
|||
| void | |||
| ImagingSectionEnter(ImagingSectionCookie *cookie) { | |||
| #ifdef WITH_THREADING | |||
There was a problem hiding this comment.
I've tried to measure performance penalty for saving state.
Empty function call:
In [2]: %timeit Image.core.test_threading()
64.1 ns ± 0.842 ns per loop (mean ± std. dev. of 7 runs, 10000000 loops each)With ImagingSectionEnter/ImagingSectionLeave:
In [6]: %timeit Image.core.test_threading()
109 ns ± 0.951 ns per loop (mean ± std. dev. of 7 runs, 10000000 loops each)
homm
changed the title
|
LGTM, This probably deserves a changelog entry -- as technically it's possible that people have been editing this. |
| #endif | ||
|
|
||
| #ifdef WITH_UNSHARPMASK | ||
| /* Kevin Cazabon's unsharpmask extension */ |
There was a problem hiding this comment.
Just for clarity - you're removing 'Kevin Cazabon' presumably because the code has been modified over time?
There was a problem hiding this comment.
If the reason were due to modifications over time, I would have included additional names accordingly. The actual reason is that I was unsure of the specific value this information provides in the comments. However, if this is important, I can revert the change.
|
Please mention this in the release notes: https://github.com/python-pillow/Pillow/blob/main/docs/releasenotes/11.0.0.rst |
by @radarhere, lost during rebase
|
@hugovk @wiredfool |
Rationale