Added ImageDraw circle() #8085
Merged
Added ImageDraw circle() #8085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yay295
reviewed
May 26, 2024
hugovk
requested changes
May 27, 2024
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
hugovk
reviewed
May 27, 2024
…te it is new Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
for more information, see https://pre-commit.ci
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
radarhere
reviewed
May 27, 2024
…[float] instead of Coords, radius to float Co-authored-by: Andrew Murray <3112309+radarhere@users.noreply.github.com>
I've added it to the release notes but am not quite sure how the unit tests work, especially the parametrization :/ |
Merged
|
I've created void4#1 with my suggestion for a test - I've copied To provide some information though, parametrization is essentially a loop - it runs the test with different items from a sequence. The idea is that if a particular scenario fails, pytest will clearly let us know which item from the parametrization sequence is the culprit. If you're interested more info, you can read up at https://docs.pytest.org/en/7.4.x/how-to/parametrize.html |
|
Thank you - merged :) |
radarhere
approved these changes
May 27, 2024
|
Thank you! |
radarhere
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8083
Implements the ImageDraw.circle feature as described and desired in the issue