Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed direct invocation of setup.py #8027

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Conversation

radarhere
Copy link
Member

Addresses python-pillow/docker-images#207 (comment) and #5896 (comment)

Pillow/Makefile

Lines 4 to 8 in c250a44

clean:
python3 setup.py clean
rm src/PIL/*.so || true
rm -r build || true
find . -name __pycache__ | xargs rm -r || true

This removes python3 setup.py clean.

From https://github.com/pypa/setuptools/blob/main/setuptools/_distutils/command/clean.py, all it does is remove the 'build_temp' and 'build_base' directories. If I print those variables on my local machine, they are 'build/temp.macosx-14.0-arm64-cpython-38' and 'build', and we're already removing the 'build' directory ourselves.

@hugovk hugovk merged commit e542c9f into python-pillow:main Apr 29, 2024
40 of 54 checks passed
@radarhere radarhere deleted the clean branch April 29, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants