Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use functools.cached_property in ImageStat #7952

Merged
merged 3 commits into from
Apr 16, 2024
Merged

Use functools.cached_property in ImageStat #7952

merged 3 commits into from
Apr 16, 2024

Conversation

nulano
Copy link
Contributor

@nulano nulano commented Apr 7, 2024

Changes proposed to ImageStat in this pull request:

  • Replace custom caching with functools.cached_property
  • Add type hints.
  • Move documentation from rst file to docstrings to include type hints in docs.

@radarhere radarhere mentioned this pull request Apr 16, 2024
Closed
hugovk
hugovk reviewed Apr 16, 2024
View reviewed changes
src/PIL/ImageStat.py Outdated Show resolved Hide resolved
@nulano @hugovk
ImageStat: simplify call to Image.histogram(mask)
8b62538 
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
nulano
nulano commented Apr 16, 2024
View reviewed changes
src/PIL/ImageStat.py Outdated Show resolved Hide resolved
@nulano @radarhere
ImageStat: simplify if block
2e73bed 
Co-authored-by: Andrew Murray <3112309+radarhere@users.noreply.github.com>
@hugovk hugovk merged commit 0e90c1c into python-pillow:main Apr 16, 2024
52 of 55 checks passed
@hugovk
Copy link
Member

hugovk commented Apr 16, 2024

Thanks!

@nulano nulano deleted the types-imagestat branch April 16, 2024 18:04
@radarhere radarhere changed the title Use functools.cached_property and add type hints to ImageStat Use functools.cached_property in ImageStat Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk left review comments

@radarhere radarhere radarhere approved these changes

Assignees
No one assigned
Labels
Type hints
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nulano @hugovk @radarhere