-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document that QoiImagePlugin uses Python for decoding #7937
Conversation
Shall we also mention https://github.com/kodonnell/qoi or https://pypi.org/project/qoi/? It's not a Pillow plugin but can be a useful alternative. |
I've pushed a commit. Now that AppVeyor is skipped, I was able to do so quite quickly! |
docs/handbook/image-file-formats.rst
Outdated
Pillow identifies and reads images in Quite OK Image format. | ||
Pillow reads images in Quite OK Image format, using a Python decoder. If you wish to | ||
write code specifically for this format, https://pypi.org/project/qoi is an alternative | ||
library that interfaces with NumPy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mention C somehow, so they know it's faster?
library that interfaces with NumPy. | |
library written in C that interfaces with NumPy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"written in C" sounds to me like the entire library is in C. How about "that uses C to decode the image"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, something like that's fine too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, I've pushed a commit for that.
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Co-authored-by: Ondrej Baranovič <ondreko.tiba@gmail.com>
Resolves #7922
#7922 (comment)