-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fromarray: add type hints #7936
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
4915f19
fromarray: add type hints
adamjstewart 8e47a6f
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 37ed8c3
Try type comment
adamjstewart 8a63980
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 5d19151
Python 3.10+
adamjstewart e85a84b
Added SupportsArrayInterface
radarhere 92dfb02
Merge pull request #1 from radarhere/types/fromarray
adamjstewart 84238bd
Merge branch 'main' into types/fromarray
radarhere c655dc0
Use a property
adamjstewart File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since (I assume) this is not intended to be exported, I would expect we either want this to be private, i.e.
or in a private module, i.e.
PIL._typing.SupportsArrayInterface
.@radarhere what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was modelling this after our implementation of
SupportsGetMesh
.#7812 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like the difference is that
SupportsGetMesh
is a Pillow protocol, whereasSupportsArrayInterface
seems to be a numpy protocol. Similarly, we havePIL._typing.SupportsRead
for a builtin Python protocol. I would therefore expect users to either use the actual numpy type (e.g.numpy.ndarray
) or define their own protocol.@hugovk Do you have any thoughts as the author of the quoted comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, let's go for
SupportsArrayInterface
, it's probably more useful that way, and it's only a small class. We an always deprecate/remove later if needed.