-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move installation.rst to installation/*.rst #7832
Conversation
My biggest concern is linkrot, existing links out will break and result in 404s. For example, answers on Stack Overflow will no longer link to the correct place. |
Is there a way to redirect links like this? https://pillow.readthedocs.io/en/stable/installation.html#building-from-source With the preview: https://pillow--7832.org.readthedocs.build/en/7832/installation.html#building-from-source It now only goes to the ToC: https://pillow--7832.org.readthedocs.build/en/7832/installation/index.html |
@hugovk Hmmm. Possibly if we add redirects on RTD according to pypa/packaging.python.org#1401 (comment) (with the core issue being whether or not link fragments are handled by the HTTP specification.) At that point, the discussion becomes more about weighing the benefit of adding navigation links to the installation section sidebar vs. breaking SO links, or SEO or whatever. I'm pretty happy with adding |
- Add index - Move content to sections - Rearrange sections
- For example, installation.html now redirects to installation/index.html
for more information, see https://pre-commit.ci
a9aee08
to
fde1ccb
Compare
- Re-add installation.rst
@hugovk @radarhere OK to merge this one? 🤔 |
Hold on to your butts |
Sorry for the late reply! I think this is mostly fine, the original page was very large and it definitely looks much better for most of these to be their own page. 👍 I've opened #7858 with some little tweaks. |
Changes proposed in this pull request: