Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved __future__ import to beginning of file #7637

Merged
merged 1 commit into from
Dec 26, 2023

Conversation

radarhere
Copy link
Member

@radarhere radarhere commented Dec 25, 2023

Helps #2625.

oss-fuzz coverage has started failing after #7631 - https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=65341&sort=-opened&can=1&q=proj%3Apillow

Syntax error in /src/Pillow/Tests/oss-fuzz/fuzz_font.py
File "/src/Pillow/Tests/oss-fuzz/fuzz_font.py", line 27
from __future__ import annotations
^
SyntaxError: from __future__ imports must occur at the beginning of the file

@hugovk
Copy link
Member

hugovk commented Dec 26, 2023

I'm surprised the linters didn't catch it. Do you know what oss-fuzz is "Analyzing" when it fails and if other files will trigger it? Or we can merge and see the next build.

@radarhere
Copy link
Member Author

While the initial report was about Tests/oss-fuzz/fuzz_font.py, my attempt to replicate gave an error about Tests/oss-fuzz/fuzz_pillow.py, so I've updated that as well.

My attempts to convince my oss-fuzz fork to look at this PR's branch aren't working however, so no, I can't guarantee that there aren't other fixes that need to be made.

@hugovk hugovk merged commit 36b40f7 into python-pillow:main Dec 26, 2023
56 checks passed
@radarhere radarhere deleted the fuzz branch December 26, 2023 10:54
@radarhere radarhere changed the title Moved __future__ import to beginning of file Moved __future__ import to beginning of file Dec 29, 2023
@radarhere
Copy link
Member Author

#7649 was the solution to this in the end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants