Install cibuildwheel from requirements file #7581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radarhere
reviewed
Nov 28, 2023
radarhere
approved these changes
Nov 28, 2023
radarhere
reviewed
Nov 28, 2023
.github/renovate.json
Outdated
| }, | ||
| { | ||
| "groupName": "requirements-cibw.txt", | ||
| "matchFileNames": [".ci/requirements-cibw.txt"] |
There was a problem hiding this comment.
Are you sure that renovate won't handle this automatically? https://docs.renovatebot.com/modules/manager/pip_requirements/#file-matching
There was a problem hiding this comment.
I'm not sure. Shall we leave this file as is, and check when the next release comes out?
There was a problem hiding this comment.
I don't think we'd need to wait until the next release. I think if we merged the PR without this change, then we could see if #6604 started listing the file or not.
There was a problem hiding this comment.
Changes to this file dropped.
There was a problem hiding this comment.
Yep, now that this is merged, it's there!
So Renovate can update them all at the same time
hugovk
force-pushed
the
requirements-cibw
branch
from
d323921 to
106f3bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps #7390.
Switch back to the PyPI-installed cibuildwheel for GitHub Actions, also use it from Travis CI.
The upcoming Windows wheel build can't use the action, so Renovate can update all three at the same time.