Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use --config-settings in external libraries list in installation.rst #7564

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Use --config-settings in external libraries list in installation.rst #7564

merged 2 commits into from
Nov 20, 2023

Conversation

nulano
Copy link
Contributor

@nulano nulano commented Nov 20, 2023

These two references to the build flags were missed in #7171.

hugovk
hugovk approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hugovk hugovk added the automerge Automatically merge PRs that are ready label Nov 20, 2023
@radarhere radarhere mentioned this pull request Nov 20, 2023
Merged
@radarhere
Copy link
Member

I feel a bit weird about

Starting with Pillow 3.0.0, libjpeg is required by default, but may be disabled with the -C jpeg=disable flag.

since "libjpeg is required by default" is since Pillow 3.0.0, but -C jpeg=disable isn't until much later. My suggestion is to split this into two sentences? nulano#24

@hugovk hugovk removed the automerge Automatically merge PRs that are ready label Nov 20, 2023
@hugovk hugovk merged commit 9694cfc into python-pillow:main Nov 20, 2023
8 checks passed
@nulano nulano deleted the config-docs branch November 20, 2023 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radarhere radarhere radarhere approved these changes

@hugovk hugovk hugovk approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nulano @radarhere @hugovk