Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention defusedxml and olefile in installation instructions #7509

Merged
merged 3 commits into from
Nov 3, 2023

Conversation

radarhere
Copy link
Member

Alternative to #7502

Under 'Basic Installation', mention that olefile can additionally be installed to allow Pillow to read FPX and
MIC images.

docs/installation.rst Outdated Show resolved Hide resolved
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
docs/installation.rst Outdated Show resolved Hide resolved
Co-authored-by: Ondrej Baranovič <nulano@nulano.eu>
@radarhere radarhere changed the title Mention olefile in installation instructions Mention defusedxml and olefile in installation instructions Nov 1, 2023
@F30
Copy link

F30 commented Nov 2, 2023

I think tkinter should also be mentioned here. It is maintained as part of the Python standard library, but but packaged separately by most distributions. That unfortunately means you cannot install it from PyPI, but depending on where you installed Python from, you will need something like python3-tk.

See also #7502 (comment).

@radarhere
Copy link
Member Author

@F30 has said that they are in favour this change by itself, so I'm going to merge this.

I originally intended this as an alternative, but it has ended up as an addendum. I think it will be simpler to make any changes regarding tkinter in #7502

@radarhere radarhere merged commit 1c2f2c7 into python-pillow:main Nov 3, 2023
4 of 5 checks passed
@radarhere radarhere deleted the olefile branch November 3, 2023 08:16
@radarhere radarhere mentioned this pull request Nov 11, 2023
@radarhere
Copy link
Member Author

radarhere commented Nov 17, 2023

I think tkinter should also be mentioned here. It is maintained as part of the Python standard library, but but packaged separately by most distributions. That unfortunately means you cannot install it from PyPI, but depending on where you installed Python from, you will need something like python3-tk.

Pillow uses defusedxml and olefile to read image data. I don't think Pillow uses tkinter, it just interfaces with it. If you don't have tkinter installed, you are not missing out on any Pillow functionality.

I also don't expect it to be common for people to install Pillow so that they can manipulate images, and then think about how to display those images in a fully fledged UI. I think it would be far more common for people to decide to build a UI with Python, and then look for a library to prepare images for that. In other words, I think it would make more sense for tkinter to suggest users install Pillow - actually, it does!

@F30
Copy link

F30 commented Nov 22, 2023

Pillow uses defusedxml and olefile to read image data. I don't think Pillow uses tkinter, it just interfaces with it. If you don't have tkinter installed, you are not missing out on any Pillow functionality.

(Text removed.)

Lets' continue that discussion over in #7509 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants