Fixed bug when reading BC5S DDS images #7401
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7386
In #5501, I added BC5 reading. When I did so, I added the following code to bring SNORM data into the UNORM range.
Pillow/src/libImaging/BcnDecode.c
Lines 121 to 122 in fce23dd
However, the resulting PNG in our test suite has artifacts - look at the lower middle and upper right of the image.
This was accepted at the time, but #7386 has raised the question again.
Thinking about it now, if the goal is to move from -128 - 127 to 0 to 255, then
seems like another answer - and indeed, it produces a result without artifacts.