Release refinement #7074
Merged
Release refinement #7074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radarhere
reviewed
Apr 9, 2023
radarhere
reviewed
Apr 9, 2023
| and copy into `dist/` | ||
| and copy into `dist/`. For example using [GitHub CLI](https://github.com/cli/cli): | ||
| ```bash | ||
| gh release download --dir dist --pattern "*.whl" --repo python-pillow/pillow-wheels |
There was a problem hiding this comment.
I gather you were thinking that this command would be run from the main repository, so that all of the files would be in one neat 'dist' directory.
However, in the previous point, the user cloned and navigated into pillow-wheels. So I feel like this is confusing. It would be good to either clarify that this should be run from the main repository, or if this is run from pillow-wheels, then --repo python-pillow/pillow-wheels is unnecessary.
There was a problem hiding this comment.
That's right, I ran both these commands from the main repo, and agree this is confusing. Will clarify!
There was a problem hiding this comment.
Added cb68187 (and rebased in the PyQt workaround).
hugovk
force-pushed
the
release-refinement
branch
from
60c4ab3 to
cb68187
Compare
radarhere
approved these changes
Apr 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some updates to the release checklist, I followed these for 9.5.0.
First, I moved the
git push --allfrom near the start (after removing.dev0from the version and updatingCHANGES.rst), to near the end (after incrementing and adding.dev0to the version).The reason: the CI does a lot of building during releases and there's a lot of waiting around for the release manager. We only need the tags pushed early to build the Windows wheels via
git push --tags. The Linux and macOS wheels are built using their own dedicated wheel builder. Thegit push --alljust delays the CI from building all these wheels.So
git push --allwhich pushesmainand9.5.xcan come after all the wheel building.Next, during the "Binary Distributions" stage, it says to download the Windows wheels (once they're ready); then do some things to kick off the macOS and Linux wheel builder and download once ready.
Let's flip the order. Even if Windows wheels were ready (and they won't be yet), it's better to get the Mac/Linux CI queued up first.
Finally, I used the GitHub CLI
ghto download all the wheels before uploading them. Saves a lot of clicking in the UI! So let's include example commands for next time.(Aside:
gh co 1234is a really handy command for checking out a PR for local testing.)