Round duration when saving animated WebP images #6996
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps #7015
Alternative to #6977. This uses
round()
instead ofint()
to better approximate the data, and has a test using one of our existing images.Animated PNGs can have float durations
Pillow/src/PIL/PngImagePlugin.py
Line 677 in cdf5fd4
but when WebP goes to save the duration, it expects an integer.
Pillow/src/PIL/WebPImagePlugin.py
Line 308 in cdf5fd4
Pillow/src/_webp.c
Lines 206 to 209 in cdf5fd4
The WebP API itself also expects the duration to be an integer. See https://developers.google.com/speed/webp/docs/container-api#webpanimencoderadd
So this PR rounds the duration.