-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log expected & actual color in image access tests #6899
Log expected & actual color in image access tests #6899
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, here's a variable naming suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
If I break the test in main, I get
If I break the test with this branch, I get
I can see that the argument that the 'where' lines being removed makes it tidier, but I'm not convinced that the values need to be part of the error message, as they're already listed in the next line? It is listed in the summary now as
where the actual value wouldn't be listed otherwise. I'm not opposed to that, I just wonder if this is trying to fight against pytest's decision to have the summary not include more details. |
The only change is from "color 32766" to "expected 32766 got 32767". I don't think that's excessive for an error message. Also, if a message isn't provided to the |
No description provided.