Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to install Pillow from a directory #6756

Merged
merged 3 commits into from
Nov 28, 2022

Conversation

radarhere
Copy link
Member

Suggestion for #6755

@hugovk
Copy link
Member

hugovk commented Nov 26, 2022

The page goes a bit like this:

Building From Source
--------------------

External Libraries
^^^^^^^^^^^^^^^^^^

[General info about dependencies]

[Then straight onto how to install from source from PyPI, archive, or Git]
Build Options
^^^^^^^^^^^^^

[Info about options]
Building on macOS
^^^^^^^^^^^^^^^^^

[How to install dependencies]

[How to install from source from PyPI, or archive]
Building on Windows
^^^^^^^^^^^^^^^^^^^

[Use wheels, or check `winbuild`]
Building on Windows using MSYS2/MinGW
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

[How to install dependencies]

[How to install from source from PyPI]
Building on FreeBSD
^^^^^^^^^^^^^^^^^^^

[How to install dependencies]

[How to install from source from PyPI]
Building on Linux
^^^^^^^^^^^^^^^^^

[How to install dependencies]
Building on Android
^^^^^^^^^^^^^^^^^^^

[How to install dependencies]

So we have the install instructions repeated in the External Libraries and in some of the Building sections.

Can we tidy this up a bit somehow?

@radarhere
Copy link
Member Author

radarhere commented Nov 27, 2022

Ok, see what you think of this idea - I've pushed a commit to move the build instructions for Pillow itself after all of the external library instructions.

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better, thanks!

docs/installation.rst Outdated Show resolved Hide resolved
docs/installation.rst Outdated Show resolved Hide resolved
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@hugovk
Copy link
Member

hugovk commented Nov 28, 2022

Thank you!

(Build failures unrelated.)

@hugovk hugovk merged commit a257016 into python-pillow:main Nov 28, 2022
@radarhere radarhere deleted the source branch November 28, 2022 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants