Don't reassign crc on ChunkStream close #6627
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picking a commit from #2941
Pillow/src/PIL/PngImagePlugin.py
Lines 160 to 164 in bdbf59d
Pillow/src/PIL/PngImagePlugin.py
Lines 191 to 192 in bdbf59d
Ok, so when it is closing, it sets
fp
andqueue
toNone
, fair enough. What iscrc
?Pillow/src/PIL/PngImagePlugin.py
Line 204 in bdbf59d
...it's a method? I don't see why this should be set to
None
.#2935 shows that it used to be sometimes set to
crc_skip
, but that still doesn't explain it to me.Looking at that PR, I conclude that
Pillow/src/PIL/PngImagePlugin.py
Lines 226 to 227 in bdbf59d
is no longer correct, so I've also removed the second sentence in that docstring.