Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build lcms2 VC2022 #6529

Merged
merged 1 commit into from
Aug 24, 2022
Merged

Build lcms2 VC2022 #6529

merged 1 commit into from
Aug 24, 2022

Conversation

radarhere
Copy link
Member

"Test Windows" failure is failing in main.

The log contains https://github.com/python-pillow/Pillow/runs/7988137153?check_suite_focus=true#step:22:113

fatal error C1047: The object or library file 'D:\a\Pillow\Pillow\winbuild\build\lib\lcms2_static.lib' was created by a different version of the compiler than other objects like 'build\temp.win32-3.7\Release\src_imagingcms.obj'; rebuild all objects and libraries with the same compiler

So this PR switches lcms2 from VC2019 to VC2022.

@hugovk hugovk added the automerge Automatically merge PRs that are ready label Aug 24, 2022
@mergify mergify bot merged commit 39f5b05 into python-pillow:main Aug 24, 2022
@radarhere radarhere deleted the windows branch August 24, 2022 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk approved these changes

Assignees
No one assigned
Labels
automerge Automatically merge PRs that are ready Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radarhere @hugovk