-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for reading ATI1/ATI2 (BC4/BC5) DDS images #6457
Conversation
This commit adds support for loading DDS with ATI1 and ATI2 fourcc pixel format
I haven't found the ATI1 texture yet, I will add a test for ATI1 when I find texture Test texture is taken from Zombie Army 4 |
Quick question, how should I go about DDS cube maps? Does pillow support layers or something like it? |
Pillow has a concept of 'frames'. While used for the different images for in an animated GIF, they are also used for the different layers in a PSD. You might want to look at https://github.com/python-pillow/Pillow/blob/main/src/PIL/PsdImagePlugin.py |
Is that something that can be distributed under Pillow's license as part of our test suite? |
I'll replace them with selfmade textures in next commit |
@radarhere Do you have any estimations of when this PR will be merged? I have other PR in progress that needs changes from this one |
All looks good. My only suggestion is to rearrange the order of the formats - https://github.com/REDxEYE/Pillow/pull/1/files I think this can be merged after that. |
Sort formats by n
Good idea, I forgot to sort them. I'm also working on a full rewrite of DDS plugin, using proper enums and flags with support for more pixel formats, but i'm stuck at floating point formats, is there any plans on adding RGBAF32 format or something? |
Sounds like you're talking about #1888 |
Let's also add this to the release notes. Thanks! https://pillow.readthedocs.io/en/latest/releasenotes/9.3.0.html |
Ok, I've created #6465 to add to the release notes. |
This commit adds support for loading DDS with ATI1 and ATI2 fourcc pixel format
Changes proposed in this pull request: