Only prevent repeated polygon pixels when drawing with transparency #5835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! I will test this shortly and report back! |
|
I can confirm this works in our setup, thank you! |
|
@ntninja Thank you for testing! @radarhere Thank you for the PR! Can we add tests to cover the |
|
Thanks both! |
This was referenced May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4333 prevented polygon pixels from being drawn more than once, so that the transparencies of pixels would not be combined to create an unintended result.
However, #5700 reported that this results in a speed decrease.
This PR switches back to the earlier, faster method of drawing pixels repeatedly - when drawing without transparency. This means that the slower method to avoid the transparency problem is not used when it does not need to be used.