For special image modes, revert default resize resampling to NEAREST #5411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 17, 2021
radarhere
force-pushed
the
resize_default
branch
from
8759a26 to
7c0344b
Compare
homm
approved these changes
Apr 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps #4402
#4255 changed the default
resampleargument forresize()to BICUBIC, with the goal of being more user-friendly. However, it turned out to not be more user-friendly for IMAGING_TYPE_SPECIAL modes, where we don't currently support resampling, except for NEAREST - leading to the "image has wrong mode" in the issue.This PR switches back to NEAREST if the image is IMAGING_TYPE_SPECIAL, so that the default
resamplevalue once again works for those modes.Looking at the code, IMAGING_TYPE_SPECIAL applies to mode with a custom number of bits: a semicolon in their mode.