-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.9-dev: Upgrade setuptools #4784
3.9-dev: Upgrade setuptools #4784
Conversation
The newest setuptools v49.2.0 warns:
(From pypa/setuptools#2256 / pypa/setuptools#2230) And results in a build error:
https://travis-ci.org/github/hugovk/Pillow/jobs/707725016 Importing master...hugovk:3.9-upgrade-setuptools2 https://travis-ci.org/github/hugovk/Pillow/builds/707729489 And upgrading setuptools for all Python versions on Travis also has the same build error (not tested on Mac/Windows/other CIs): master...hugovk:3.9-upgrade-setuptools3 https://travis-ci.org/github/hugovk/Pillow/builds/707730154 Will report to setuptools, and they're already reconsidering the strategy: pypa/setuptools#2259. |
Reported: pypa/setuptools#2261. |
Also macOS (and Linux) on GHA: (Not Windows, but I've not checked it actually upgraded.) |
You only updated the MSYS script, and that build (surprisingly) passes with 49.1.3. I added the upgrade to the main Windows build and it also fails: |
I've concluded that this error was also introduced in setuptools 47.3.2. I've created pypa/setuptools#2297 to resolve. |
Hopefully this will pass now pypa/setuptools#2297 is merged and setuptools 49.3.2 is released 🤞 |
Just copying my comment from #4858: GHA 3.9-dev has been updated and now also has a broken setuptools version. |
4b75fb9
to
94e3575
Compare
Thanks, updated to upgrade on GHA for 3.9-dev as well. |
94e3575
to
1a3f5b6
Compare
The setuptools fix pypa/setuptools#2249 for #4769 has been released in setuptools v49.1.3, so we can require that version or newer.
Created as draft as there are further build problems from new changes in setuptools, will add comments.