-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added braces to C #4618
Added braces to C #4618
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be ok not to rebase/force push until approved? It'll be easier to review single additional commits later. Thanks!
if (has_data) {\ | ||
yproj[y] = 1;\ | ||
}\ | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a note.
Before:
Visually, both if
blocks are indented as if they are both in the for
loop.
But it wouldn't make sense for both to be in the for
loop, so it was functionally correct before, and the change makes it clearer.
A few other grep -r " else$" . --include "*.c"
./src/libImaging/BoxBlur.c: else
./src/libImaging/BoxBlur.c: else
./src/libImaging/BoxBlur.c: else
./src/libImaging/RawEncode.c: } else
./src/libImaging/JpegEncode.c: } else
./src/libImaging/XbmEncode.c: } else
./src/libImaging/GifDecode.c: } else
./src/_webp.c: } else
./src/_webp.c: } else The
|
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Ok, I've done a pass over the code using your |
See #4493