Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added coverage for Docker GHA #4316

Merged
merged 2 commits into from
Dec 30, 2019

Conversation

radarhere
Copy link
Member

Resolves #4212 if this works.

.github/workflows/test-docker.yml Outdated Show resolved Hide resolved
.github/workflows/test-docker.yml Outdated Show resolved Hide resolved
Co-Authored-By: Hugo van Kemenade <hugovk@users.noreply.github.com>
@hugovk
Copy link
Member

hugovk commented Dec 30, 2019

Thank you, looks good!


Total coverage with this PR is 87.99%:

The same branch, with Docker jobs removed from Travis CI, is also at 87.99%:


I see there's an exception with coveralls-merge on GHA:

coveralls.exception.CoverallsException: Not on TravisCI. You have to provide either repo_token in .coveralls.yml or set the COVERALLS_REPO_TOKEN env var.

But there's a different exception with coveralls-merge on Travis:

UnicodeDecodeError: 'utf-8' codec can't decode byte 0xf1 in position 99: invalid continuation byte

Let's not worry about that for now, at least it's the same end result for both.


Maybe we keep the Dockers in Travis until January?

@radarhere radarhere closed this Dec 30, 2019
@radarhere radarhere deleted the docker_coverage branch December 30, 2019 12:07
@radarhere radarhere restored the docker_coverage branch December 30, 2019 12:08
@radarhere radarhere reopened this Dec 30, 2019
@radarhere radarhere merged commit cbabd87 into python-pillow:master Dec 30, 2019
@radarhere radarhere deleted the docker_coverage branch December 30, 2019 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add coverage for Docker builds
2 participants