-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed Image size property to be read-only by default #3203
Conversation
0040020
to
ab90792
Compare
Will this break existing code? Is it okay to break existing code in this case? If not, should we have a deprecation warning first? |
I think that this is about explicitly raising an error at when a user performs incorrect behaviour, rather than allowing their incorrect behaviour to produce bugs later on. In the issue that started this, the user was receiving an error when saving. This just moves the error one step earlier. The only situation I can think of where we might not want to immediately throw an error is for people writing their own image format plugins - they will now need to assign to |
In light of #3044 (comment), where setting the size directly on a TIFF image is given as a solution, I have changed setting the size of a TIFF image to be only deprecated. |
Let's also mention it in the release notes. |
Okay, I've added a commit for release notes. |
Suggestion for #2071