Revert #3780 for PyPy3 as it hasn't been updated yet. (#3935)

Revert #3780 for PyPy3 as it hasn't been updated yet.
python-pillow · Jul 2, 2019 · aaca672 · aaca672
2 parents eedac36 + 14ddfd3
commit aaca672
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 7 deletions.
diff --git a/Tests/test_imagefont.py b/Tests/test_imagefont.py
@@ -465,8 +465,9 @@ def test_unicode_pilfont(self):
             font.getsize(u"’")
 
     @unittest.skipIf(
-        sys.platform.startswith("win32") and sys.version.startswith("2"),
-        "requires Python 3.x on Windows",
+        sys.platform.startswith("win32")
+        and (sys.version.startswith("2") or hasattr(sys, "pypy_translation_info")),
+        "requires CPython 3.x on Windows",
     )
     def test_unicode_extended(self):
         # issue #3777

diff --git a/src/_imagingft.c b/src/_imagingft.c
@@ -327,7 +327,7 @@ getfont(PyObject* self_, PyObject* args, PyObject* kw)
 static int
 font_getchar(PyObject* string, int index, FT_ULong* char_out)
 {
-#if PY_VERSION_HEX < 0x03000000
+#if (PY_VERSION_HEX < 0x03030000) || (defined(PYPY_VERSION_NUM))
     if (PyUnicode_Check(string)) {
         Py_UNICODE* p = PyUnicode_AS_UNICODE(string);
         int size = PyUnicode_GET_SIZE(string);
@@ -336,7 +336,7 @@ font_getchar(PyObject* string, int index, FT_ULong* char_out)
         *char_out = p[index];
         return 1;
     }
-
+#if PY_VERSION_HEX < 0x03000000
     if (PyString_Check(string)) {
         unsigned char* p = (unsigned char*) PyString_AS_STRING(string);
         int size = PyString_GET_SIZE(string);
@@ -345,6 +345,7 @@ font_getchar(PyObject* string, int index, FT_ULong* char_out)
         *char_out = (unsigned char) p[index];
         return 1;
     }
+#endif
 #else
     if (PyUnicode_Check(string)) {
         if (index >= PyUnicode_GET_LENGTH(string))
@@ -373,7 +374,7 @@ text_layout_raqm(PyObject* string, FontObject* self, const char* dir, PyObject *
         goto failed;
     }
 
-#if PY_VERSION_HEX < 0x03000000
+#if (PY_VERSION_HEX < 0x03030000) || (defined(PYPY_VERSION_NUM))
     if (PyUnicode_Check(string)) {
         Py_UNICODE *text = PyUnicode_AS_UNICODE(string);
         Py_ssize_t size = PyUnicode_GET_SIZE(string);
@@ -392,8 +393,9 @@ text_layout_raqm(PyObject* string, FontObject* self, const char* dir, PyObject *
                 goto failed;
             }
         }
-
-    } else if (PyString_Check(string)) {
+    }
+#if PY_VERSION_HEX < 0x03000000
+    else if (PyString_Check(string)) {
         char *text = PyString_AS_STRING(string);
         int size = PyString_GET_SIZE(string);
         if (! size) {
@@ -410,6 +412,7 @@ text_layout_raqm(PyObject* string, FontObject* self, const char* dir, PyObject *
             }
         }
     }
+#endif
 #else
     if (PyUnicode_Check(string)) {
         Py_UCS4 *text = PyUnicode_AsUCS4Copy(string);