-
-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enables python 3.13 #871
base: master
Are you sure you want to change the base?
Enables python 3.13 #871
Conversation
Enables py 3.13
…hon-pendulum-master
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like something equivalent was merged in #863?
uses: snok/install-poetry@v1 | ||
with: | ||
virtualenvs-create: true | ||
virtualenvs-in-project: true | ||
installer-parallel: true | ||
version: 1.8.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this change needed? I'm sure it's okay, but it does mean one extra step in the CI supply chain to worry about, so if it's not 100% strictly required, given it's not an official poetry action I'd favour sticking with just "official" curl approach?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we are using github default runners, simple pipx install poetry=={version}
is all we need.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem to revert back to curl. Should I upgrade poetry to 2.0 for the whole project? lock file is not compatible. (that's why I used the action - I could pick the right version easily)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For ease of review I'd say keep the poetry upgrade/changes to a separate PR please
@@ -1,6 +1,6 @@ | |||
[project] | |||
name = "pendulum" | |||
version = "3.0.0" | |||
version = "3.0.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: Please don't change the version in the PR like this, a sepearte release PR will make this change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure!
this is a continuation of #863. We had to upgrade O3 version again because we could not build Windows wheels. This again required us to handle some deprecations. I think @Secrus was able to merge the relevant commit. We'll come back with more fixes. We will be testing updated wheels via our private PyPI and then update this PR. |
We have merged some updates to Poetry and CI setup. @rudolfix could you rebase the changes? |
@Secrus also we added |
This PR makes
pendulum
work on Python 3.13. We are using it a lot in our library: https://github.com/dlt-hub/dlt and initially considered forking pendulum to make it work on Python 3.13. Maybe there's a chance to merge this into main project?I'm sure some of the changes are going too far. We are open to revert them if there's an interest from maintainers to merge this PR :)
We are running this PR with our own tests on all basic architectures and we do not see any problems
happy to revert/change