Ensure non-blocking mypy compatibility #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks reasonable, thanks! |
|
The follow-up message here said that the original issue was caused by
out-of-date mypy, so that shouldn't be happening if you're properly up to
date?
A release will go out at some point in the next few days regardless.
…On Wed, Feb 21, 2024 at 10:10 AM Daniel Vojtko ***@***.***> wrote:
Any chance you guys can release a patch version with this, please? It's
breaking our CI. 🙏
—
Reply to this email directly, view it on GitHub
<#130 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACQQXSNIIUBRNVOOZKEEZDYUYE5XAVCNFSM6AAAAABDO7NPMKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJWHA4DEOJQG4>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
|
@Julian when is this going to be released? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mypyfollows imports to third-party dependency packages by default. If the package has any blocking errors,mypycannot perform any type checking.This PR ensures that
referencingis compatible with the latest version ofmypyand will not produce any fatal blocking errors.These checks are added to CI through
nox. Type checks withinreferencingare still done withpyright.This also fixes an invalid
type: ignoresyntax issue (#128), where non-PEP484 syntax caused a blocking error inmypy<0.990.