Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't build universal wheels for Python 3-only #841

Merged
merged 2 commits into from
Sep 28, 2021

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Sep 28, 2021

Universal wheels are for when you need to support both Python 2 and 3:

https://packaging.python.org/guides/distributing-packages-using-setuptools/#wheels

Before:

  • jsonschema-0.1.dev1+gdbda4f7-py2.py3-none-any.whl

After:

  • jsonschema-0.1.dev2+g97057ed-py3-none-any.whl

Also ignore some build dirs generated by running python -m build locally.

@codecov
Copy link

codecov bot commented Sep 28, 2021

Codecov Report

Merging #841 (3da1fcf) into main (dbda4f7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #841   +/-   ##
=======================================
  Coverage   98.30%   98.30%           
=======================================
  Files          19       19           
  Lines        3124     3124           
  Branches      378      378           
=======================================
  Hits         3071     3071           
  Misses         41       41           
  Partials       12       12           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbda4f7...3da1fcf. Read the comment docs.

@Julian
Copy link
Member

Julian commented Sep 28, 2021

Thanks!

@Julian Julian merged commit f91f3ec into python-jsonschema:main Sep 28, 2021
@hugovk hugovk deleted the rm-universal branch September 28, 2021 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants