Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it compatible with Python 3.7+ #41

Closed
wants to merge 5 commits into from

Conversation

Mariatta
Copy link

@Mariatta Mariatta commented Feb 12, 2019

We observed the following deprecation warning in Python 3.7.1+:

Travis CI log
PR: python/bedevere#154
Issue: python/bedevere#153

../../../virtualenv/python3.8-dev/lib/python3.8/site-packages/uritemplate/variable.py:363: in dict_test
    return isinstance(value, (dict, collections.MutableMapping))

DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working

In this PR I updated the import to avoid the DeprecationWarning and add Python 3.7 to travis CI matrix.

Thanks for this useful library!

@sigmavirus24
Copy link
Collaborator

This was already fixed in #40 but hasn't been released yet (it would seem)

@Mariatta
Copy link
Author

Thanks for the info! I confirmed that if we were to use the latest version, it will work.
I've updated my PR just to make the tests running under Python 3.7+ environments. Thanks again.

@hugovk
Copy link
Contributor

hugovk commented Dec 6, 2019

Looks like this has been superseded by #45.

@Mariatta Mariatta deleted the make-it-work-with-py37 branch January 7, 2021 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants