Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude hidden paths in files output #170

Merged
merged 2 commits into from
Mar 10, 2023
Merged

Exclude hidden paths in files output #170

merged 2 commits into from
Mar 10, 2023

Conversation

ionite34
Copy link
Member

@ionite34 ionite34 commented Mar 10, 2023

To avoid cluttering files output with cache and configs from libraries like matplotlib, this will exclude parsing output files with a hidden (leading ".") directory or file name.

@coveralls
Copy link

Coverage Status

Coverage: 85.532% (-0.7%) from 86.266% when pulling 9b31db9 on files-exclude-hidden into 8a85b86 on main.

@MarkKoz
Copy link
Member

MarkKoz commented Mar 10, 2023

Do we still ignore files starting with an underscore? Don't remember if it was implemented.

@ionite34
Copy link
Member Author

ionite34 commented Mar 10, 2023

Do we still ignore files starting with an underscore? Don't remember if it was implemented.

Yes, via the default nsjail / config files_pattern: str = "**/[!_]*" Though this actually only works on files, not recursively ignoring any file inside directories with leading underscores.

If we want to make it also ignore everything in underscored directories it would have to be another conditional instead of glob. Since it seems glob patterns cannot condition the name of recursive folder matches.

@mbaruh mbaruh merged commit 671f8d5 into main Mar 10, 2023
@mbaruh mbaruh deleted the files-exclude-hidden branch March 10, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants