Fix #300 : enable huge_tree in XMLParser to handle very big events #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobixen
reviewed
Mar 8, 2023
tobixen
reviewed
Mar 8, 2023
tobixen
reviewed
Mar 8, 2023
|
Tests are failing because rootdir is not the one I expected, fixed in new commit |
|
"tox -e style", and then it's ready? |
|
(the 80 character line length restriction in PEP-8 is a terrible constraint sometimes) |
|
Will you rebase it into one commit and press the "ready for review"-button? :-) |
|
All right, should be good now. |
|
Thanks for the review :) |
|
I can't promise a quick release of caldav v1.3.0 this time, but hopefully in a week or two. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A proposition to fix #300
Activating huge_tree in XMLParser allow to handle very big caldav events.