-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ruff for linting #949
Merged
Add ruff for linting #949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40eefb4
to
b973635
Compare
Codecov Report
@@ Coverage Diff @@
## master #949 +/- ##
=======================================
Coverage 90.53% 90.53%
=======================================
Files 24 24
Lines 4394 4394
=======================================
Hits 3978 3978
Misses 416 416 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
774970c
to
1ee74c4
Compare
This was referenced Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #944 (supersedes it)
This PR adds linting via
ruff
, a very fast linter, and applies a whole bunch of fixes suggested by it. Most of them are mechanical (via--fix
), but some were gently hand-tweaked.