Fix conftest.py compatibility with pytest 4.3 #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While pytest in tox.ini is explicitly set to be 3.3.2, in Fedora 31 we are about to update to a newer version of pytest. In order to be able to test babel, we need pytest 4.3 support. This adds support for pytest 4.3 without breaking support for 3.3.2.
Codecov Report
@@ Coverage Diff @@
## master #635 +/- ##
=======================================
Coverage 90.42% 90.42%
=======================================
Files 24 24
Lines 4083 4083
=======================================
Hits 3692 3692
Misses 391 391Continue to review full report at Codecov.
|
|
@hroncok Thank you! We could by all means upgrade to pytest 4, so if you feel like it, please add the other required changes too. :) |
|
Should I pin pytest at 4.3.1? |
That's fine. Thank you! |
|
Oh, btw, the same changes will need to be done in the travis and appveyor configs too (due to Legacy Reasons). Would you mind doing that too, @hroncok? :) |
|
sure, later today |
|
amended |
|
Thank you! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While pytest in tox.ini is explicitly set to be 3.3.2, in Fedora 31 we are about to update to a newer version of pytest. In order to be able to test babel, we need pytest 4.3 support.
This adds support for pytest 4.3 without breaking support for 3.3.2.
Switching to 4.3 in tox.ini is left at the discretion of the maintainers.