Add a strict mode to parse_decimal()
#590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #590 +/- ##
==========================================
- Coverage 90.3% 90.29% -0.02%
==========================================
Files 24 24
Lines 4105 4120 +15
==========================================
+ Hits 3707 3720 +13
- Misses 398 400 +2
Continue to review full report at Codecov.
|
akx
requested changes
Jun 16, 2018
babel/numbers.py
Outdated
| proper = format_decimal(r, locale=locale, decimal_quantization=False) | ||
| if string != proper and string.rstrip('0') != (proper + decimal_symbol): | ||
| raise NumberFormatError( | ||
| "%r is not a properly formatted decimal number" % string |
There was a problem hiding this comment.
It would be super nice to have the expected value in the error here.
Maybe even
class MisparsedNumberError(NumberFormatError):
def __init__(self, message, original, parsed, expected):
super(MisparsedNumberError, self).__init__(message)
self.original = original
self.parsed = parsed
self.expected = expected
# ...
raise MisparsedNumberError(
"%r is not properly formatted; parsed as %r, expected %r" % (string, r, proper),
original=string,
parsed=r,
expected=proper,
)so users could have more visibility into what went wrong.
babel/numbers.py
Outdated
| try: | ||
| return decimal.Decimal(string.replace(get_group_symbol(locale), '') | ||
| .replace(get_decimal_symbol(locale), '.')) | ||
| r = decimal.Decimal(string.replace(group_symbol, '') |
There was a problem hiding this comment.
Could the name r be something more descriptive?
Changaco
force-pushed
the
strict-decimal-parsing
branch
from
ff24ed9 to
71d80d6
Compare
Changaco
force-pushed
the
strict-decimal-parsing
branch
from
71d80d6 to
b5f6f36
Compare
|
Ready for second review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch adds a
strictflag to theparse_decimalfunction. When set toTruean exception is raised if the input number is formatted in a weird way. This is determined by comparing the string to the result offormat_decimal().Closes #589.