Prevent update_catalog from stomping over comments in existing po files #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update_catalog from stomping over existing user comments in .po files.
gitmate-bot
added
process/pending review
pending review
size/XS
and removed
process/pending review
labels
Current coverage is 90.15%@@ master #418 diff @@
==========================================
Files 24 24
Lines 3951 3952 +1
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 3562 3563 +1
Misses 389 389
Partials 0 0
|
|
Thanks for the patch, @Mabusto! Can you add a test that verifies the behavior? |
|
Can we get this merged in? We're running into the same issue. I'd commit a test if I could, but I have no idea how. |
|
Hi there, This is a relatively simple change. I see that it is marked for review. Is there anything I can do to help move this along and get it merged in? |
akx
added a commit
to akx/babel
that referenced
this pull request
May 27, 2019
akx
added a commit
to akx/babel
that referenced
this pull request
May 27, 2019
akx
added a commit
that referenced
this pull request
May 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pybabel updatewill ignore existing comments in a po file. This issue is outlined in greater detail here (https://babel.edgewall.org/ticket/170) and this is the suggested fix. Auto comments are not copied over here as they will work when extractor runs, but user comments are stored in the .po file, therefore will be overwritten unless they are merged in.