Fix of list index out of range error in PoFileParser.add_message when translations is empty #1135
Conversation
Co-authored-by: Tomas R <tomas.roun8@gmail.com>
…babel into PoFileParser_Patch
…sponding msgid without msgstr
|
I updated the error message and added a test. Let me know if there's any other changes that should be made! |
|
Thanks! I'll take a look later today or tomorrow (ping me in case I forget) |
Co-authored-by: Tomas R <tomas.roun8@gmail.com>
Co-authored-by: Tomas R <tomas.roun8@gmail.com>
|
Sorry for the delay, it's been a busy couple of days. I just added a couple more test cases! |
tests/messages/test_pofile.py
Outdated
| with pytest.raises(pofile.PoFileError) as e: | ||
| pofile.read_po(buf, abort_invalid=True) | ||
| assert(str(e.value)) == "missing msgstr for msgid 'foo' on 1" |
Co-authored-by: Tomas R <tomas.roun8@gmail.com>
Co-authored-by: Tomas R <tomas.roun8@gmail.com>
…babel into PoFileParser_Patch
|
Made those extra changes. Thanks for sticking with me as I work through everything! |
Thank you for working on the fix! It's looking good to me but I don't have commit rights in this repo so I'm pinging @akx 🙂 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1135 +/- ##
==========================================
+ Coverage 91.26% 91.31% +0.05%
==========================================
Files 27 27
Lines 4602 4618 +16
==========================================
+ Hits 4200 4217 +17
+ Misses 402 401 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Thank you! The test was a bit buggy, so I went ahead and fixed that – and also that we don't do (a tiny bit of) extra work if we'd end up raising an error next anyway. |
Addresses #1134
Previously, the
add_messagefunction would try to access the PoFileParser object's translations list without any checks. However, when an invalid po file is provided, this can lead to an index out of range error.This PR adds a check to the
_finish_current_messagefunction and raises aninvalid_pofileexception when the messages list is populated and translations is empty. This also adds a dummy translation to the translations list to avoid the index out of range error when aninvalid_pofileexception is treated as a warning rather than raised.