-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support 't' specifier in keywords #1015
Conversation
Note that there is a test for |
CI fails with a seemingly unrelated error. |
For new tests, prefer plain
You can write a test that uses exercises the extraction function with a bespoke |
(Rebasing on master) |
Thank you. I've added a test and fixed the bug that it caught.
|
Anything else needed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of comments – sorry for the delay...
Codecov Report
@@ Coverage Diff @@
## master #1015 +/- ##
==========================================
+ Coverage 90.91% 90.94% +0.03%
==========================================
Files 25 25
Lines 4358 4375 +17
==========================================
+ Hits 3962 3979 +17
Misses 396 396
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Thank you for your review, @akx. The PR should be improved quite a bit now, especially with regard to documentation and code clarity. |
@akx Gentle ping? |
@jeanas Sorry, I was on holiday and all that 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple requests remaining. Thanks for your patience 😅
Now addressed. |
Ping? |
@akx Gentle ping. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, and sorry for the long review delays!
Thank you! |
Fixes #1014