Make Converter a kind of adapter, fix converters.pipe #1328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hynek
force-pushed
the
chained-converters
branch
from
83a067f
to
043bab3
Compare
Tinche
approved these changes
Aug 5, 2024
hynek
commented
Aug 6, 2024
Comment on lines
+2727
to
+2745
| self.__call__ = { | ||
| (False, False): self._takes_only_value, | ||
| (True, False): self._takes_instance, | ||
| (False, True): self._takes_field, | ||
| (True, True): self._takes_both, | ||
| }[self.takes_self, self.takes_field] | ||
|
|
||
| def _takes_only_value(self, value, instance, field): | ||
| return self.converter(value) | ||
|
|
||
| def _takes_instance(self, value, instance, field): | ||
| return self.converter(value, instance) | ||
|
|
||
| def _takes_field(self, value, instance, field): | ||
| return self.converter(value, field) | ||
|
|
||
| def _takes_both(self, value, instance, field): | ||
| return self.converter(value, instance, field) | ||
|
|
There was a problem hiding this comment.
@Tinche how about now? here, the dict even makes a bit of sense ;) bummer we need self, otherwise I would make it a class var too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like piped converters are hosed. 😳
There's still the issue when a Converter comes last in a pipe, but this fixes at least #1327 and that pipe used to pass nonsense into converters.