Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race condition on task retry #487

Merged
merged 2 commits into from
Nov 29, 2024
Merged

Fix race condition on task retry #487

merged 2 commits into from
Nov 29, 2024

Conversation

RB387
Copy link
Contributor

@RB387 RB387 commented Nov 26, 2024

Related issue:
#482

@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main     #487      +/-   ##
==========================================
- Coverage   96.27%   96.10%   -0.18%     
==========================================
  Files          11       11              
  Lines        1074     1078       +4     
  Branches      209      190      -19     
==========================================
+ Hits         1034     1036       +2     
- Misses         19       21       +2     
  Partials       21       21              
Files with missing lines Coverage Δ
arq/worker.py 97.37% <100.00%> (+0.20%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3914e48...aaa9585. Read the comment docs.

@RB387
Copy link
Contributor Author

RB387 commented Nov 29, 2024

@samuelcolvin @chrisguidry 🙏

Copy link
Contributor

@chrisguidry chrisguidry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me, thanks @RB387!

@chrisguidry chrisguidry merged commit 2f752e2 into python-arq:main Nov 29, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants