Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mypy #403

Closed
wants to merge 3 commits into from
Closed

Update mypy #403

wants to merge 3 commits into from

Conversation

phy1729
Copy link
Contributor

@phy1729 phy1729 commented May 26, 2023

Mypy changed the default for the implicit_optional setting, so I included that in this PR as well. Error codes are shown by default now and the ollow_imports = 'silent' setting is no longer required for mypy to pass.

@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Merging #403 (9799c7c) into main (9109c2e) will decrease coverage by 0.20%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #403      +/-   ##
==========================================
- Coverage   98.66%   98.47%   -0.20%     
==========================================
  Files          11       11              
  Lines        1052     1052              
  Branches      199      199              
==========================================
- Hits         1038     1036       -2     
- Misses          6        7       +1     
- Partials        8        9       +1     
Impacted Files Coverage Δ
arq/connections.py 95.20% <ø> (ø)
arq/jobs.py 98.15% <ø> (ø)
arq/worker.py 99.16% <ø> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9109c2e...9799c7c. Read the comment docs.

rossmacarthur pushed a commit to hunchdata/arq that referenced this pull request Mar 4, 2024
@samuelcolvin
Copy link
Member

Thanks so much for the contribution, this is replaced by #439 where I've fixed lots of related things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants