-
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add job_id to JobDef, closing #376 #378
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #378 +/- ##
=======================================
Coverage 98.66% 98.67%
=======================================
Files 11 11
Lines 1052 1053 +1
Branches 199 199
=======================================
+ Hits 1038 1039 +1
Misses 6 6
Partials 8 8
Continue to review full report in Codecov by Sentry.
|
@JonasKs hi 👋 |
Hi @gerazenobi 😊 |
@JonasKs thanks for the quick answer ! Just to confirm: there is no workaround to get from queued job ( |
On phone, but I believe you can generate an ID yourself, queue task with that ID set, and then use the ID (which you now have) to get job data? |
@JonasKs indeed, however I need to be able to enqueue multiple jobs of the "same nature" hence I can't use custom_ids unfortunately: once an id is used then we can't delete the job nor re-enqueue the job again. |
Would love to see this added 🙏 |
This would be very helpful! |
Thanks so much and sorry for the delay in reviewing and merging. |
|
This probably need a good review. I looked at the discussion in #198, which had a good reason to use
.get('id')
overd['id']
.Close #376