Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add job_id to JobDef, closing #376 #378

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

JonasKs
Copy link
Collaborator

@JonasKs JonasKs commented Dec 15, 2022

This probably need a good review. I looked at the discussion in #198, which had a good reason to use .get('id') over d['id'].

Close #376

@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Merging #378 (6f80c7e) into main (bfa8e68) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 6f80c7e differs from pull request most recent head 405e4fd. Consider uploading reports for the commit 405e4fd to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #378   +/-   ##
=======================================
  Coverage   98.66%   98.67%           
=======================================
  Files          11       11           
  Lines        1052     1053    +1     
  Branches      199      199           
=======================================
+ Hits         1038     1039    +1     
  Misses          6        6           
  Partials        8        8           
Impacted Files Coverage Δ
arq/worker.py 99.16% <ø> (ø)
arq/connections.py 95.23% <100.00%> (+0.03%) ⬆️
arq/jobs.py 98.15% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfa8e68...405e4fd. Read the comment docs.

@gerazenobi
Copy link

gerazenobi commented May 15, 2023

@JonasKs hi 👋
Any chance this gets released soon ?

@JonasKs
Copy link
Collaborator Author

JonasKs commented May 15, 2023

Hi @gerazenobi 😊
It needs a review from @samuelcolvin, who's a busy man these days (pydantic v2 is around the corner). I have no estimate, but I'd assume some time after v2 is out 😊

@gerazenobi
Copy link

gerazenobi commented May 15, 2023

@JonasKs thanks for the quick answer !

Just to confirm: there is no workaround to get from queued job (JobDef) to actual job (Job) correct ? (without doing any custom tracking on my end)

@JonasKs
Copy link
Collaborator Author

JonasKs commented May 15, 2023

On phone, but I believe you can generate an ID yourself, queue task with that ID set, and then use the ID (which you now have) to get job data?

@gerazenobi
Copy link

@JonasKs indeed, however I need to be able to enqueue multiple jobs of the "same nature" hence I can't use custom_ids unfortunately: once an id is used then we can't delete the job nor re-enqueue the job again.

@rossmacarthur
Copy link

Would love to see this added 🙏

rossmacarthur pushed a commit to hunchdata/arq that referenced this pull request Sep 19, 2023
@KShah707
Copy link

This would be very helpful!

@KShah707 KShah707 mentioned this pull request Mar 28, 2024
@samuelcolvin samuelcolvin merged commit e27ad93 into python-arq:main Apr 1, 2024
@samuelcolvin
Copy link
Member

Thanks so much and sorry for the delay in reviewing and merging.

@samuelcolvin
Copy link
Member

v0.26.0b1 is released, please try it, I'll release v0.26 at the end of the week, see #441.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to get jobs in order to abort
5 participants