Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent duplicate jobs when result exists #138

Merged
merged 1 commit into from
Aug 2, 2019

Conversation

samuelcolvin
Copy link
Member

@samuelcolvin samuelcolvin commented Aug 1, 2019

fix #137

@codecov
Copy link

codecov bot commented Aug 1, 2019

Codecov Report

Merging #138 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #138      +/-   ##
==========================================
+ Coverage   98.73%   98.73%   +<.01%     
==========================================
  Files           8        8              
  Lines         630      631       +1     
  Branches       87       87              
==========================================
+ Hits          622      623       +1     
  Misses          6        6              
  Partials        2        2

1 similar comment
@codecov
Copy link

codecov bot commented Aug 1, 2019

Codecov Report

Merging #138 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #138      +/-   ##
==========================================
+ Coverage   98.73%   98.73%   +<.01%     
==========================================
  Files           8        8              
  Lines         630      631       +1     
  Branches       87       87              
==========================================
+ Hits          622      623       +1     
  Misses          6        6              
  Partials        2        2

@samuelcolvin samuelcolvin merged commit 06c05d5 into master Aug 2, 2019
@samuelcolvin samuelcolvin deleted the duplicate-job-results branch August 2, 2019 15:26
@powellchristoph
Copy link

Greetings! So this change recently broke some code for us and while I can understand the rational for it, how do we work around it? There doesn't appear to be a way to cleanup results once the jobs have been completed?

@samuelcolvin
Copy link
Member Author

If you don't want to look at job results set the duration arq keeps results for to a smaller number (or 0 to not keep them at all).

Or you could manually delete the jobs results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resubmission of job with same id causes conflict
2 participants