Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tox: remove requires: pip>=20.3.1 #8125

Merged
merged 1 commit into from
Dec 12, 2020
Merged

tox: remove requires: pip>=20.3.1 #8125

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ envlist =
py37-freeze
docs
docs-checklinks
requires = pip >= 20.3.1
Copy link
Member

@antonblr antonblr Dec 12, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was added to replicate CI environment locally, while working on #8119 (CI was running pip 20.3.1, but tox didn't use the latest locally)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, it would be interesting to figure out what this error means

tox.exception.Error: Error: break infinite loop provisioning within /opt/hostedtoolcache/Python/3.8.6/x64/bin/python missing ['pip>=20.3.1']

but I'm taking a bit of a shortcut here to get the upcoming release going.

But even so I think we might want to leave this requires out; IIUC, until people get the new pip in their distro it would make the tox env creation a little longer? I haven't looked into it too much though.

Copy link
Member

@antonblr antonblr Dec 12, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be related tox-dev/tox#1518 nvm, it seems to install virtualenv-20.2.2


[testenv]
commands =
Expand Down