-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Constrain more_itertools for Python 2.7 compatibility #4774
Constrain more_itertools for Python 2.7 compatibility #4774
Conversation
Thanks a lot @sambrightman for providing this PR and testing that it works.
Oh I believe it does, as definitely the Python 2 users which are facing this problem would like to know about it in the CHANGELOG. 👍 |
Ok, changelog entry added. |
GitHub tip: when this is merged, only the first issue will be autoclosed. Repeat the keyword to autoclose both: Docs: https://help.github.com/articles/closing-issues-using-keywords/ |
Thanks! In this case #4772 is already closed. |
Codecov Report
@@ Coverage Diff @@
## master #4774 +/- ##
==========================================
+ Coverage 95.67% 95.69% +0.01%
==========================================
Files 113 113
Lines 25012 25012
Branches 2484 2484
==========================================
+ Hits 23930 23935 +5
+ Misses 764 762 -2
+ Partials 318 315 -3
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #4774 +/- ##
==========================================
+ Coverage 95.67% 95.69% +0.01%
==========================================
Files 113 113
Lines 25012 25012
Branches 2484 2484
==========================================
+ Hits 23930 23935 +5
+ Misses 764 762 -2
+ Partials 318 315 -3
Continue to review full report at Codecov.
|
…tertools issue Issue: pytest-dev/pytest#4770 Resolution: pytest-dev/pytest#4774
… latest version of pytest has fixed this pytest-dev/pytest#4774
… latest version of pytest has fixed this pytest-dev/pytest#4774
Fixes #4772, #4770.
There was some discussion in #4770 that maybe this can be written slightly differently but it worked for me like this.
I assume this doesn't require a changelog entry.